Repository navigation
fix(vmm): persist guest events outside the global state lock - #1271
Merged
Merged
Conversation
This was referenced Sep 20, 2026
kvinwang
force-pushed
the
fix/vmm-event-io
branch
from
September 24, 2026 09:02
b172627 to
a791b46
Compare
kvinwang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
vm_event_report(HostApi.Notify) wroteinstance.info(safe_write, with fsync) and thestartedflag while holding the global VMM state mutex, so a slow disk stalled every other API call and VM.Fix
Update the in-memory event state under the lock, then release it before the file write.
Verification
cargo test -p dstack-vmm(209 passed), fmt and clippy clean.Fixes #1269.